assertNoAsyncErrors more queue types and msg arg #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Converting some existing code to use `assertNoAsyncErrors` I found cases where the error queue was `AssertionError` not `Throwable` and some cases where the message was used to provide more specific info about the source/context of the errors. Modifications: Add additional overload for message and allow wildcard for queue type. Result: More useful `assertNoAsyncErrors`.
bondolo
commented
May 26, 2021
servicetalk-test-resources/src/main/java/io/servicetalk/test/resources/TestUtils.java
Show resolved
Hide resolved
tkountis
approved these changes
May 27, 2021
|
Failure is due to #1579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Converting some existing code to use
assertNoAsyncErrorsI foundcases where the error queue was
AssertionErrornotThrowableandsome cases where the message was used to provide more specific info
about the source/context of the errors.
Modifications:
Add additional overload for message and allow wildcard for queue type.
Result:
More useful
assertNoAsyncErrors.