Deprecate append method on all filter factories
#1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: All `*FilterFactory` interfaces currently implement default `append` method that helps to chain filters in order of append. Because internally it uses wrapping approach, it can hide `HttpExecutionStrategyInfluencer` implementation of the passed filter factory. To avoid that, users have to use a method on the client/server builder instead. Modifications: - Deprecate `append` method on all filter factories; - Add `FilterFactoryUtils` test fixture as the replacement utility for tests; Result: Users won't hide `HttpExecutionStrategyInfluencer` impl when they chain filters.
|
Build failure #1579 |
bondolo
approved these changes
May 25, 2021
servicetalk-http-api/src/testFixtures/java/io/servicetalk/http/api/FilterFactoryUtils.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/testFixtures/java/io/servicetalk/http/api/FilterFactoryUtils.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/testFixtures/java/io/servicetalk/http/api/FilterFactoryUtils.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/testFixtures/java/io/servicetalk/http/api/FilterFactoryUtils.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jun 21, 2021
Motivation: `append` method on each filter factory was deprecated in apple#1578 and can be removed now. Modifications: - Remove `append` method from `ConnectionFactoryFilter`, `GrpcServiceFilterFactory`, `MultiAddressHttpClientFilterFactory`, `StreamingHttpClientFilterFactory`, `StreamingHttpConnectionFilterFactory`, `StreamingHttpServiceFilterFactory`. Result: No deprecated methods on filter factory API.
idelpivnitskiy
added a commit
that referenced
this pull request
Jun 21, 2021
Motivation: `append` method on each filter factory was deprecated in #1578 and can be removed now. Modifications: - Remove `append` method from `ConnectionFactoryFilter`, `GrpcServiceFilterFactory`, `MultiAddressHttpClientFilterFactory`, `StreamingHttpClientFilterFactory`, `StreamingHttpConnectionFilterFactory`, `StreamingHttpServiceFilterFactory`. Result: No deprecated methods on filter factory API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
All
*FilterFactoryinterfaces currently implement defaultappendmethod that helps to chain filters in order of append. Because
internally it uses wrapping approach, it can hide
HttpExecutionStrategyInfluencerimplementation of the passed filterfactory. To avoid that, users have to use a method on the client/server
builder instead.
Modifications:
appendmethod on all filter factories;FilterFactoryUtilstest fixture as the replacement utility fortests;
Result:
Users won't hide
HttpExecutionStrategyInfluencerimpl when they chainfilters.