Fix "assume" statements in tests #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: During migration to jUnit5 in apple#1521, some of the "assume" statements were moved before the initialization of parameters. As the result, those "assume" statements did not work. Modifications: - `NettyHttpServerTest`: move `ignoreTestWhen` after `setUp`; - `ServiceTalkToNettyContentCodingCompatibilityTest` execute `start()` after "assume" checks; - Minor cosmetic changes in other test classes: make methods `static`, use static import, etc. Result: `NettyHttpServerTest` is kept ignored for now.
bondolo
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
During migration to jUnit5 in #1521, some of the "assume" statements
were moved before the initialization of parameters. As the result,
those "assume" statements did not work.
Modifications:
NettyHttpServerTest: moveignoreTestWhenaftersetUp;ServiceTalkToNettyContentCodingCompatibilityTestexecutestart()after "assume" checks;
static,use static import, etc.
Result:
NettyHttpServerTestis kept ignored for now.