Deprecate HTTP/gRPC offloadWithThreadAffinity #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The method used for ensuring thread affinity used by the HTTP/gRPC builders will be removed in a near future version of ServiceTalk. The offered alternative is to use a single threaded executor which provides the same affinity guarantee. Modifications: Methods are marked deprecated. Some existing tests which reference the thread based signal offloader are converted to the default signal offleader. Result: Deprecation warning provided.
idelpivnitskiy
approved these changes
May 17, 2021
...nternal/src/test/java/io/servicetalk/concurrent/api/publisher/PublishAndSubscribeOnTest.java
Outdated
Show resolved
Hide resolved
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: The method used for ensuring thread affinity used by the HTTP/gRPC builders will be removed in a near future version of ServiceTalk. The offered alternative is to use a single threaded executor which provides the same affinity guarantee. Modifications: Methods are marked deprecated. Some existing tests which reference the thread based signal offloader are converted to the default signal offleader. Result: Deprecation warning provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The method used for ensuring thread affinity used by the HTTP/gRPC builders,
offloadWithThreadAffinity()will be removed in a near future version of ServiceTalk. The offered alternative is to use a single threaded executor which provides the same affinity guarantee.Modifications:
The
offloadWithThreadAffinity()builder methods are marked deprecated. Some existing tests which reference the thread based signal offloader are converted to the default signal offloader.Result:
Deprecation warning provided for methods which will eventually be removed.