Fix ProxyTunnel to always use the address instead of the hostname. #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ProxyTunnel was returning the hostname instead of the address, which in some configurations where the IPv4 is preferred but the DNS resolves in both IPv4 and IPv6 for the loopback hostname, cause connectivity issues. Modifications: Modified the ProxyTunnel to always return the address for the clients to connect to. Result: More stable test.
normanmaurer
approved these changes
May 14, 2021
idelpivnitskiy
requested changes
May 14, 2021
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/ProxyTunnel.java
Outdated
Show resolved
Hide resolved
…/ProxyTunnel.java Co-authored-by: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
idelpivnitskiy
approved these changes
May 14, 2021
|
Thank you! |
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
…apple#1563) Motivation: ProxyTunnel was returning the `localhost` hostname instead of the IP-address, which in some configurations where the IPv4 is preferred but the DNS resolves in both IPv4 and IPv6 for the loopback hostname, cause connectivity issues. Modifications: Modified the ProxyTunnel to always return the IP-address for the clients to connect to. Result: More stable test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ProxyTunnel was returning the
localhosthostname instead of the IP-address, which in some configurationswhere the IPv4 is preferred but the DNS resolves in both IPv4 and IPv6 for the loopback hostname,
cause connectivity issues.
Modifications:
Modified the ProxyTunnel to always return the IP-address for the clients to connect to.
Result:
More stable test.