Trigger NettyConnectionClosing#onClosing() on HTTP/2 channel-inactive
#1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `onClosing()` should be completed as soon as possible to notify LB and concurrency controller that this connection is going to close soon. `H2ParentConnectionContext` does not complete `onClosing` until user closure is invoked on the event-loop (there is no need to wait for that) and misses a few other pipeline events. Modifications: - Complete `onClosing` as soon as we `initiateGracefulClose`; - Complete `onClosing` for the following pipeline events: `channelInactive`, `handlerRemoved`, `SslCloseCompletionEvent`, `ChannelInputShutdownReadComplete`, `ChannelOutputShutdownEvent` because all of them indicate that the connection is going to close; Result: `NettyConnectionClosing#onClosing()` is triggered sooner for HTTP/2 connections.
idelpivnitskiy
changed the title
NettyConnectionClosing#onClosing() for HTTP/2NettyConnectionClosing#onClosing() earlier
bondolo
approved these changes
May 13, 2021
idelpivnitskiy
changed the title
NettyConnectionClosing#onClosing() earlierNettyConnectionClosing#onClosing() on HTTP/2 channel-inactive
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
…ve (apple#1560) Motivation: `onClosing()` should be completed as soon as it's known that the connection is going to close to notify LB and concurrency controller. Modifications: - Complete `onClosing` when `channelInactive` or `handlerRemoved` event is propagated; - Do not complete `onClosing` on `channelRead(Http2GoAwayFrame)` because it will be completed inside `KeepAliveManager.initiateGracefulClose`; - Test that `KeepAliveManager.initiateGracefulClose` runs the `Runnable`; Result: `NettyConnectionClosing#onClosing()` is triggered for `channelInactive` and `handlerRemoved` events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
onClosing()should be completed as soon as it's known that the connection isgoing to close to notify LB and concurrency controller.
Modifications:
onClosingwhenchannelInactiveorhandlerRemovedevent ispropagated;
onClosingonchannelRead(Http2GoAwayFrame)becauseit will be completed inside
KeepAliveManager.initiateGracefulClose;KeepAliveManager.initiateGracefulCloseruns theRunnable;Result:
NettyConnectionClosing#onClosing()is triggered forchannelInactiveandhandlerRemovedevents.