Fix flaky closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived
#1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived` may be in a situation when the 2nd request actually gets written after client receives `GO_AWAY` frame from the server. Therefore, `Http2Exception` is also excepted. We will use `IOException` for simplicity and consistency. Modifications: - `assertClosedChannelException` should expect either `ClosedChannelException` or `IOException`; Result: `closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived` is not flaky.
tkountis
approved these changes
May 17, 2021
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
…d` (apple#1557) Motivation: `closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived` may be in a situation when the 2nd request actually gets written after client receives `GO_AWAY` frame from the server. Therefore, `Http2Exception` is also excepted. We will use `IOException` for simplicity and consistency. Modifications: - `assertClosedChannelException` should expect either `ClosedChannelException` or `IOException`; Result: `closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived` is not flaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceivedmay be ina situation when the 2nd request actually gets written after client
receives
GO_AWAYframe from the server. Therefore,Http2Exceptionisalso excepted. We will use
IOExceptionfor simplicity and consistency.Modifications:
assertClosedChannelExceptionshould expect eitherClosedChannelExceptionorIOException;Result:
closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceivedis notflaky.