Script that checks API/ABI compatibility between versions #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's hard to track API/ABI changes and list everything correctly in release notes. This script produces summary of all changes made between versions. Modifications: - Add `./scripts/japicmp.sh`; Result: Scripts that summarizes all API/ABI changes.
bondolo
reviewed
May 12, 2021
scripts/japicmp.sh
Outdated
|
|
||
| # All servicetalk modules except: servicetalk-benchmarks, servicetalk-bom, servicetalk-examples, servicetalk-gradle-plugin-internal: | ||
| # All servicetalk modules except: | ||
| # servicetalk-benchmarks, servicetalk-bom, servicetalk-examples, servicetalk-gradle-plugin-internal | ||
| ARTIFACTS="$(ls -d -- */ | grep 'servicetalk-' | sed 's/.$//' | \ |
There was a problem hiding this comment.
I usually prefer find vs ls if the names may contain spaces.
There was a problem hiding this comment.
It's known that the names of modules don't contain spaces
bondolo
approved these changes
May 12, 2021
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: It's hard to track API/ABI changes and list everything correctly in release notes. This script produces a summary of all changes made between versions. Modifications: - Add `./scripts/japicmp.sh`; Result: Script that summarizes all API/ABI changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's hard to track API/ABI changes and list everything correctly in
release notes. This script produces a summary of all changes made
between versions.
Modifications:
./scripts/japicmp.sh;Result:
Script that summarizes all API/ABI changes.