Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore public API changes for transport-netty-internal #1549

Merged
merged 1 commit into from
May 11, 2021
Merged

Restore public API changes for transport-netty-internal #1549

merged 1 commit into from
May 11, 2021

Conversation

idelpivnitskiy
Copy link
Member

Motivation:

All public API breaking changes should be deferred until 0.41.0.
Even for internal modules there is a risk of having mixed version
numbers in the classpath.

Modifications:

Result:

No public API changes for 0.40.0.

@idelpivnitskiy
Restore public API changes for transport-netty-internal
9ca7205 
Motivation:

All public API breaking changes should be deferred until 0.41.0.
Even for internal modules there is a risk of having mixed version
numbers in the classpath.

Modifications:

- Restore `BuilderUtils#useEpoll` and `BuilderUtils#useKQueue` methods
that were removed in apple#1539.

Result:

No public API changes for 0.40.0.
@idelpivnitskiy idelpivnitskiy requested a review from bondolo May 11, 2021 22:13
@idelpivnitskiy
Copy link
Member Author

japicmp reported:

***! MODIFIED CLASS: PUBLIC FINAL io.servicetalk.transport.netty.internal.BuilderUtils  (not serializable)
	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
	===  UNCHANGED SUPERCLASS: java.lang.Object (<- java.lang.Object)
	---! REMOVED METHOD: PUBLIC(-) STATIC(-) boolean useEpoll(io.netty.channel.EventLoopGroup)
	---! REMOVED METHOD: PUBLIC(-) STATIC(-) boolean useKQueue(io.netty.channel.EventLoopGroup)

@idelpivnitskiy idelpivnitskiy merged commit 42be7ff into apple:main May 11, 2021
@idelpivnitskiy idelpivnitskiy deleted the BuilderUtils branch May 11, 2021 23:05
idelpivnitskiy added a commit to idelpivnitskiy/servicetalk that referenced this pull request May 11, 2021
@idelpivnitskiy
Revert "Restore public API changes for transport-netty-internal (ap…
21ac860 
…ple#1549)"

This reverts commit 42be7ff.
hbelmiro pushed a commit to hbelmiro/servicetalk that referenced this pull request May 23, 2021
@idelpivnitskiy @hbelmiro
Restore public API changes for transport-netty-internal (apple#1549)
aa9f5af 
Motivation:

All public API breaking changes should be deferred until 0.41.0.
Even for internal modules there is a risk of having mixed version
numbers in the classpath.

Modifications:

- Restore `BuilderUtils#useEpoll` and `BuilderUtils#useKQueue` methods
that were removed in apple#1539.

Result:

No public API changes for 0.40.0.
idelpivnitskiy added a commit that referenced this pull request Jun 18, 2021
@idelpivnitskiy
Revert "Restore public API changes for transport-netty-internal (#1549
0510d1c 
)" (#1550)

This reverts commit 42be7ff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bondolo bondolo bondolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idelpivnitskiy @bondolo