Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore public API changes for grpc-api #1548

Merged
merged 1 commit into from
May 11, 2021
Merged

Restore public API changes for grpc-api #1548

merged 1 commit into from
May 11, 2021

Conversation

idelpivnitskiy
Copy link
Member

Motivation:

All public API breaking changes should be deferred until 0.41.0.

Modifications:

Result:

No public API changes for 0.40.0.

@idelpivnitskiy
Restore public API changes for grpc-api
980cce5 
Motivation:

All public API breaking changes should be deferred until 0.41.0.

Modifications:

- Restore `grpc-api` that was removed in apple#1501.

Result:

No public API changes for 0.40.0.
@idelpivnitskiy idelpivnitskiy requested a review from bondolo May 11, 2021 22:07
@idelpivnitskiy
Copy link
Member Author

idelpivnitskiy commented May 11, 2021 •
edited
Loading

japicmp reported:

***! MODIFIED CLASS: PUBLIC ABSTRACT io.servicetalk.grpc.api.GrpcClientBuilder  (not serializable)
	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
	===  UNCHANGED SUPERCLASS: java.lang.Object (<- java.lang.Object)
	---! REMOVED FIELD: PROTECTED(-) STATIC(-) FINAL(-) io.servicetalk.concurrent.api.AsyncContextMap$Key GRPC_DEADLINE_KEY
***! MODIFIED INTERFACE: PUBLIC ABSTRACT io.servicetalk.grpc.api.GrpcClientMetadata  (not serializable)
	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
	===  UNCHANGED SUPERCLASS: java.lang.Object (<- java.lang.Object)
	---! REMOVED FIELD: PUBLIC(-) STATIC(-) FINAL(-) java.time.Duration GRPC_MAX_TIMEOUT
***! MODIFIED CLASS: PUBLIC ABSTRACT io.servicetalk.grpc.api.GrpcServerBuilder  (not serializable)
	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
	===  UNCHANGED SUPERCLASS: java.lang.Object (<- java.lang.Object)
	---! REMOVED FIELD: PROTECTED(-) STATIC(-) FINAL(-) io.servicetalk.concurrent.api.AsyncContextMap$Key GRPC_DEADLINE_KEY

@idelpivnitskiy idelpivnitskiy merged commit e055ea7 into apple:main May 11, 2021
@idelpivnitskiy idelpivnitskiy deleted the deadline-api branch May 11, 2021 23:05
idelpivnitskiy added a commit to idelpivnitskiy/servicetalk that referenced this pull request May 11, 2021
@idelpivnitskiy
Revert "Restore public API changes for grpc-api (apple#1548)"
266a6e0 
This reverts commit e055ea7.
hbelmiro pushed a commit to hbelmiro/servicetalk that referenced this pull request May 23, 2021
@idelpivnitskiy @hbelmiro
Restore public API changes for grpc-api (apple#1548)
7227521 
Motivation:

All public API breaking changes should be deferred until 0.41.0.

Modifications:

- Restore `grpc-api` that was removed in apple#1501.

Result:

No public API changes for 0.40.0.
idelpivnitskiy added a commit that referenced this pull request Jun 18, 2021
@idelpivnitskiy
Revert "Restore public API changes for grpc-api (#1548)" (#1551)
d02589f 
This reverts commit e055ea7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bondolo bondolo bondolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idelpivnitskiy @bondolo