Deprecate publishAndSubscribeOnOverride methods #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Refactoring of offloading is expected to remove these methods so it is important to give users forewarning to migrate to other methods. Modifications: The `publishOnOverride``, `subscribeOnOverride` and `publishAndSubscribeOnOverride` methods of `Publisher``, `Single` and `Completable` are deprecated as well as the internal methods they call are marked deprecated and an alternative suggestion is provided. Result: Users are forewarned of upcoming API change.
bondolo
added a commit
to bondolo/servicetalk
that referenced
this pull request
May 7, 2021
**Motivation**: Refactoring of offloading is expected to remove these methods so it is important to give users forewarning to migrate to other methods. **Modifications**: The `publishOnOverride`, `subscribeOnOverride` and `publishAndSubscribeOnOverride` methods of `Publisher`, `Single` and `Completable` are deprecated as well as the internal methods they call are marked deprecated and an alternative suggestion is provided. **Result**: Users are forewarned of upcoming API change.
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
**Motivation**: Refactoring of offloading is expected to remove these methods so it is important to give users forewarning to migrate to other methods. **Modifications**: The `publishOnOverride`, `subscribeOnOverride` and `publishAndSubscribeOnOverride` methods of `Publisher`, `Single` and `Completable` are deprecated as well as the internal methods they call are marked deprecated and an alternative suggestion is provided. **Result**: Users are forewarned of upcoming API change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Refactoring of offloading is expected to remove these methods so it is
important to give users forewarning to migrate to other methods.
Modifications:
The
publishOnOverride,subscribeOnOverrideandpublishAndSubscribeOnOverridemethods ofPublisher,SingleandCompletableare deprecated as well as the internal methods they callare marked deprecated and an alternative suggestion is provided.
Result:
Users are forewarned of upcoming API change.