Config test ignoreFailures via system property #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The default behaviour of Gradle is to stop the build with an error in the first module with a test failure. In some cases it is useful to run all tests to get a survey of which tests are failing. It can also be annoying if flaky tests are stopping the build from completing. This change allows configuration of the Gradle test `ignoreFailures` option to continue the build after test failures. Modifications: The `ignoreFailures` test configuration is initialized from the system property `servicetalk.test.ignoreFailures` allowing for command line configuration. `./gradlew -Dservicetalk.test.ignoreFailures=true build` Result: Dynamically configurable ignoreFailures. This feature should not be used for CI builds as it will mask build failures. Build results should always be manually examined for test failures if this option is used.
idelpivnitskiy
approved these changes
May 4, 2021
move ignoreFailures to the correct block
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: The default behaviour of Gradle is to stop the build with an error in the first module with a test failure. In some cases it is useful to run all tests to get a survey of which tests are failing. It can also be annoying if flaky tests are stopping the build from completing. Modifications: This change allows configuration of the Gradle test `ignoreFailures` option to continue the build after test failures. The `ignoreFailures` test configuration is initialized from the system property `servicetalk.test.ignoreFailures` allowing for command line configuration. `./gradlew -Dservicetalk.test.ignoreFailures=true build` Result: Dynamically configurable `ignoreFailures`. This feature should not be used for CI builds as it will mask build failures. Build results should always be manually examined for test failures if this option is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The default behaviour of Gradle is to stop the build with an error in
the first module with a test failure. In some cases it is useful to
run all tests to get a survey of which tests are failing. It can also
be annoying if flaky tests are stopping the build from completing.
Modifications:
This change allows configuration of the Gradle test
ignoreFailuresoption to continue the build after test failures. The
ignoreFailurestest configuration is initialized from the system property
servicetalk.test.ignoreFailuresallowing for command lineconfiguration.
./gradlew -Dservicetalk.test.ignoreFailures=true buildResult:
Dynamically configurable ignoreFailures. This feature should not be
used for CI builds as it will mask build failures. Build results
should always be manually examined for test failures if this option
is used.