Use UniformStreamByteDistributor for HTTP/2 connections
#1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
commented
May 3, 2021
tkountis
approved these changes
May 6, 2021
Motivation: HTTP/2 spec defines priorities for streams. However, in ST we do not expose API to assign priorities for streams and this features is rarely used in general. `Http2FrameCodecBuilder` creates connections with `WeightedFairQueueByteDistributor` by default that takes priorities into account. We can use `UniformStreamByteDistributor` to reduce overhead of managing HTTP/2 streams. Modifications: - Extend `Http2FrameCodecBuilder` to use `UniformStreamByteDistributor` for new `Http2Connection`(s); Result: Less CPU usage for HTTP/2 ~1-1.5% according to the benchmarks.
idelpivnitskiy
force-pushed
the
UniformStreamByteDistributor
branch
from
3a27000 to
5eb5e1e
Compare
idelpivnitskiy
force-pushed
the
UniformStreamByteDistributor
branch
from
5eb5e1e to
aa21c37
Compare
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: HTTP/2 spec defines priorities for streams. However, in ST we do not expose API to assign priorities for streams and this feature is rarely used in general. `Http2FrameCodecBuilder` creates connections with `WeightedFairQueueByteDistributor` by default that takes priorities into account. We can use `UniformStreamByteDistributor` to reduce overhead of managing HTTP/2 streams. Modifications: - Extend `Http2FrameCodecBuilder` to use `UniformStreamByteDistributor` for new `Http2Connection`(s); Result: Less CPU usage for HTTP/2 ~1-1.5% according to the benchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HTTP/2 spec defines priorities for streams. However, in ST we do not
expose API to assign priorities for streams and this features is rarely
used in general.
Http2FrameCodecBuildercreates connections withWeightedFairQueueByteDistributorby default that takes priorities intoaccount. We can use
UniformStreamByteDistributorto reduce overhead ofmanaging HTTP/2 streams.
Modifications:
Http2FrameCodecBuilderto useUniformStreamByteDistributorfor new
Http2Connection(s);Result:
Less CPU usage for HTTP/2 ~1-1.5% according to the benchmarks.