Enhance Buffer byte[] accessor methods javadoc #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Buffer array(), hasArray(), and arrayOffset() methods are coupled. However the javadocs don't clearly indicate their relationship which may lead to confusion. Modifications: - Clarify the relationship between Buffer array(), hasArray(), and arrayOffset() in javadocs. Result: Buffer byte[] accessor javadocs clarify the relationship between related methods.
tkountis
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Buffer array(), hasArray(), and arrayOffset() methods are coupled.
However the javadocs don't clearly indicate their relationship which may
lead to confusion.
Modifications:
arrayOffset() in javadocs.
Result:
Buffer byte[] accessor javadocs clarify the relationship between related
methods.