Fix flaky PrematureClosureBeforeResponsePayloadBodyTest#notAllHeadersReceived()
#1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sReceived()` Motivation: This test is affected by a race between propagating `onError` through `DefaultNettyConnection#enrichError` and receiving FIN from the server (`ChannelInputShutdownReadComplete`). The exception is always correct, but it can be wrapped with `CloseEventObservedException` if the FIN reached the client. Modifications: - Improve test's assertion to check the exception or its cause; Result: Fixes apple#1224.
Scottmitch
approved these changes
Apr 20, 2021
...y/src/test/java/io/servicetalk/http/netty/PrematureClosureBeforeResponsePayloadBodyTest.java
Outdated
Show resolved
Hide resolved
tkountis
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This test is affected by a race between propagating
onErrorthroughDefaultNettyConnection#enrichErrorand receiving FIN from the server(
ChannelInputShutdownReadComplete). The exception is always correct, butit can be wrapped with
CloseEventObservedExceptionif the FIN reached theclient.
Modifications:
Result:
Fixes #1224.