Restore CharSequences.newAsciiString(String) #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In ServiceTalk 0.39.0 the method `CharSequences.newAsciiString(CharSequence)` was introduced which replaced `CharSequences.newAsciiString(String)`. This was a source compatible, but binary incompatible change. All existing uses of the `String` overload could be recompiled to use the `CharSequence` overload. Existing binary code expected the `String` overload to Existing and fails with `NoSuchMethodError` at runtime. Modifications: For cases where the libraries and applications using ServiceTalk cannot be recompiled conveniently the `CharSequences.newAsciiString(String)` overload is restored. Result: Binary compatibility with libraries and applications which use `CharSequences.newAsciiString(String)` and are compiled against versions of ServiceTalk before 0.39.0 is restored.
Scottmitch
reviewed
Apr 19, 2021
| * | ||
| * @param input a character sequence containing only 8-bit ASCII characters. | ||
| * @return a {@link CharSequence} | ||
| */ |
There was a problem hiding this comment.
add @Deprecated annotation and javaodc?
There was a problem hiding this comment.
I don't want to add deprecation because the only fix for user code is to add an explicit upcast to CharSequence which will be redundant once the String method is actually removed. We should investigate solutions to add an invisible bridge method for the String overload so that source compiles to the CharSequence method but binary compatibility is maintained.
idelpivnitskiy
pushed a commit
that referenced
this pull request
Apr 20, 2021
Motivation: In ServiceTalk 0.39.0 the method `CharSequences.newAsciiString(CharSequence)` was introduced which replaced `CharSequences.newAsciiString(String)`. This was a source compatible, but binary incompatible change. All existing uses of the `String` overload could be recompiled to use the `CharSequence` overload. Existing binary code expected the `String` overload to exist and fails with `NoSuchMethodError` at runtime. Modifications: For cases where the libraries and applications using ServiceTalk cannot be recompiled conveniently the `CharSequences.newAsciiString(String)` overload is restored. Result: Binary compatibility with libraries and applications which use `CharSequences.newAsciiString(String)` and are compiled against versions of ServiceTalk before 0.39.0 is restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In ServiceTalk 0.39.0 the method
CharSequences.newAsciiString(CharSequence)was introduced whichreplaced
CharSequences.newAsciiString(String). This was a sourcecompatible, but binary incompatible change. All existing uses of the
Stringoverload could be recompiled to use theCharSequenceoverload. Existing binary code expected the
Stringoverload to be presentand fails with
NoSuchMethodErrorat runtime.Modifications:
For cases where the libraries and applications using ServiceTalk cannot
be recompiled conveniently the
CharSequences.newAsciiString(String)overload is restored.
Result:
Binary compatibility with libraries and applications which use
CharSequences.newAsciiString(String)and are compiled againstversions of ServiceTalk before 0.39.0 is restored.