release.sh: identify the remote before switching to DRYRUN mode
#1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Current version of the release script identifies the remote after the `DRYRUN` mode overrides `git` command. As the result, logs do not show which remote will be used when the `DRYRUN` mode will be off. Modifications: - Move lines that identify `remote` before the `DRYRUN` mode check; - Print a message when `DRYRUN` mode is enabled; Result: `DRYRUN` mode correctly shows the git remote.
idelpivnitskiy
changed the title
DRYRUN modeDRYRUN mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Current version of the release script identifies the remote after the
DRYRUNmode overridesgitcommand. As the result, logs do not showwhich remote will be used when the
DRYRUNmode will be off.Modifications:
remotebefore theDRYRUNmode check;DRYRUNmode is enabled;Result:
DRYRUNmode correctly shows the git remote.