Do not concatenate Publisher.empty() message body
#1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: For `HeaderUtils#setContentLength(...)`, when the `messageBody` is exactly `Publisher.empty()` there are no operators applied for the `messageBody`. In this case we do not need concatenation. Modifications: - Skip concatenation when `messageBody == empty()`; - Add tests when payloadBody is not set at all; Result: Less operators applied during request/response processing when not necessary.
|
@tkountis minor improvement, didn't think about it during review |
Scottmitch
approved these changes
Apr 15, 2021
| @@ -177,7 +177,11 @@ public boolean mapTerminal() { | |||
| final BiIntConsumer<HttpHeaders> contentLengthUpdater) { | |||
| if (messageBody == empty() || (isPayloadEmpty(metadata) && !mayHaveTrailers(metadata))) { | |||
| contentLengthUpdater.apply(0, metadata.headers()); | |||
| return from(metadata, EmptyHttpHeaders.INSTANCE).concat(messageBody.ignoreElements()); | |||
| return messageBody == empty() ? | |||
There was a problem hiding this comment.
nit: does it make sense to cache this?
final boolean messageBodyEmpty = messageBody == empty();
if (messageBodyEmpty || ..) {
return messageBodyEmpty ? ...;
}There was a problem hiding this comment.
because it's a comparison of a reference address, not sure cache will be helpful
There was a problem hiding this comment.
also hope that compiler is smart enough :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For
HeaderUtils#setContentLength(...), when themessageBodyis exactlyPublisher.empty()there are no operators applied for themessageBody.In this case we do not need concatenation.
Modifications:
messageBody == empty();Result:
Less operators applied during request/response processing when not
necessary.