H2PriorKnowledgeFeatureParityTest remove exception verification workaround #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…round Motivaiton: H2PriorKnowledgeFeatureParityTest allows for ClosedChannelException in some scenarios which should be a Http2Exception. This issue has since been fixed in netty and the workaround can be reverted. Modifications: - Remove .or(instanceOf(ClosedChannelException.class)) clause in H2PriorKnowledgeFeatureParityTest Result: H2PriorKnowledgeFeatureParityTest test verifies expected exception for h2.
Scottmitch
changed the title
|
fixed by netty/netty#11105 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivaiton:
H2PriorKnowledgeFeatureParityTest allows for ClosedChannelException in
some scenarios which should be a Http2Exception. This issue has since
been fixed in netty and the workaround can be reverted.
Modifications:
H2PriorKnowledgeFeatureParityTest
Result:
H2PriorKnowledgeFeatureParityTest test verifies expected exception for
h2.