Allow overriding key/trust managers on SslConfig builders
#1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We ask key/trust materials at the constructor because they are required arguments to build an `SslConfig`. However, users may use a single builder to build multiple `SslConfig` instances with different materials. We should let them override these arguments, if necessary. Modifications: - Make `trustManager` and `keyManager` methods public in `AbstractSslConfigBuilder`; Result: Users can override key/trust materials at `[Client|Server]SslConfigBuilder`.
Scottmitch
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We ask key/trust materials at the constructor because they are required
arguments to build an
SslConfig. However, users may use a single builderto build multiple
SslConfiginstances with different materials. We shouldlet them override these arguments, if necessary.
Modifications:
trustManagerandkeyManagermethods public inAbstractSslConfigBuilder;finalmodifier to all methods ofAbstractSslConfigBuilder;Result:
Users can override key/trust materials at
[Client|Server]SslConfigBuilder.