H1SpecExceptions add option to allow LF without proceeding CR #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The HTTP/1.x spec allows for optional support to accept LF without proceeding CR as a valid separator in some scenarios [1]. Some older implementations rely upon this behavior and interoperability would be improved by allowing opt-in support. [1] https://tools.ietf.org/html/rfc7230#section-3.5 Although the line terminator for the start-line and header fields is the sequence CRLF, a recipient MAY recognize a single LF as a line terminator and ignore any preceding CR. Modifications: - Update HttpObjectDecoder to support LF without CR Result: H1SpecExceptions allows for opt-in support for LF without proceeding CR.
|
build failure attributed to #1224 |
Scottmitch
commented
Apr 9, 2021
|
|
||
| /** | ||
| * Allows interpreting connection closures as the end of HTTP/1.1 messages if the receiver did not receive any | ||
| * part of the payload body before the connection closure. | ||
| * | ||
| * @deprecated Use {@link #prematureClosureBeforePayloadBody(boolean)}. |
There was a problem hiding this comment.
@idelpivnitskiy - this is inline with previous discussion we've had regarding builders allowing state to be controlled externally and re-usable.
idelpivnitskiy
approved these changes
Apr 10, 2021
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/H1SpecExceptions.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/HttpObjectDecoder.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/HttpRequestDecoderTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/HttpResponseDecoderTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/H1SpecExceptions.java
Show resolved
Hide resolved
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jun 21, 2021
… in apple#1475 Motivation: `H1SpecExceptions.Builder#allowPrematureClosureBeforePayloadBody()` option was deprecated in apple#1475 and can be removed now. Users can use `allowPrematureClosureBeforePayloadBody(boolean)` overload as an alternative. Modifications: - Remove `H1SpecExceptions.Builder#allowPrematureClosureBeforePayloadBody()`; Result: No deprecated `H1SpecExceptions.Builder#allowPrematureClosureBeforePayloadBody()` API.
idelpivnitskiy
added a commit
that referenced
this pull request
Jun 22, 2021
… in #1475 (#1638) Motivation: `H1SpecExceptions.Builder#allowPrematureClosureBeforePayloadBody()` option was deprecated in #1475 and can be removed now. Users can use `allowPrematureClosureBeforePayloadBody(boolean)` overload as an alternative. Modifications: - Remove `H1SpecExceptions.Builder#allowPrematureClosureBeforePayloadBody()`; Result: No deprecated `H1SpecExceptions.Builder#allowPrematureClosureBeforePayloadBody()` API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The HTTP/1.x spec allows for optional support to accept LF without
proceeding CR as a valid separator in some scenarios [1]. Some older
implementations rely upon this behavior and interoperability would be
improved by allowing opt-in support.
[1] https://tools.ietf.org/html/rfc7230#section-3.5
Although the line terminator for the start-line and header fields is
the sequence CRLF, a recipient MAY recognize a single LF as a line
terminator and ignore any preceding CR.
Modifications:
Result:
H1SpecExceptions allows for opt-in support for LF without proceeding
CR.