-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for site documentation #1461
Conversation
Motivation: The documentation produced for the servicetalk.io website uses plugins and tools which have been updated. Where practical recent versions of these dependencies should be used. Modifications: Plugins and tool dependencies used for generating and verifying the servicetalk.io site are updated to current/recent versions. Result: Current versions are used for generating documentation
I was unable to update Antora to the latest version, 2.3.4, as the local site generated contains broken links. There appears to have been a change in how the site base URL is calculated beginning in 2.2.0. |
I found the Antora 2.2.0 release notes which helped me figure out what needed to be changed so I was able to update to latest Antora, 2.3.4. I compared the generated output of the current 2.0.0 version and the 2.3.4 and there is no significant difference obvious in the HTML, it has surprisingly few differences. |
@@ -74,7 +73,8 @@ for (location in ["local", "remote"]) { | |||
|
|||
classpath = configurations.nuValidator | |||
main = "nu.validator.client.SimpleCommandLineValidator" | |||
args "--skip-non-html" // --also-check-css doesn't work (still checks css as html), so limit to html files | |||
args "--also-check-css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one of the many benefits of updating!
Should we open a GH issue for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkstyle issue, then LGTM
Looks great! Thanks for taking care of it ❤️ |
Motivation:
The documentation produced for the servicetalk.io website uses plugins
and tools which have been updated. Where practical recent versions of
these dependencies should be used.
Modifications:
Plugins and tool dependencies used for generating and verifying the
servicetalk.io site are updated to current or more recent versions.
Result:
Updated versions are used for generating documentation