Deprecate isAsciiString and replace its internal usages #1451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Minimize exposed CharSequences API and don't expose internal detail.
Modifications:
Deprecate
isAsciiString
and replace it's usages.Result:
Cleaner API.
Also attempted a solution with an
IndexOfExtractor
interface exposed directly fromCharSequences
and bench marked the two. The benefit was negligible (assuming that the JIT optimized for that particular case ie.CharSequence
) so I chose to keep simple.For reference:
* isValidIpV4AddressNew is with the IndexOfExtractor approach