Add Publisher.scanWithLifetime(ScanWithLifetimeMapper) operator #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
commented
Mar 20, 2021
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Show resolved
Hide resolved
bondolo
reviewed
Mar 22, 2021
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Outdated
Show resolved
Hide resolved
Scottmitch
reviewed
Mar 25, 2021
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
...etalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimeMapper.java
Outdated
Show resolved
Hide resolved
...cetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/ScanWithPublisherTest.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Show resolved
Hide resolved
Scottmitch
reviewed
Mar 25, 2021
...etalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimeMapper.java
Show resolved
Hide resolved
tkountis
force-pushed
the
feature/scanWithLifetime
branch
from
4ea727d to
42ee6a4
Compare
tkountis
force-pushed
the
feature/scanWithLifetime
branch
from
42ee6a4 to
28df65b
Compare
tkountis
force-pushed
the
feature/scanWithLifetime
branch
from
8d98195 to
83488fb
Compare
Scottmitch
requested changes
Apr 2, 2021
...etalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimeMapper.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithLifetimePublisher.java
Outdated
Show resolved
Hide resolved
...est/java/io/servicetalk/concurrent/reactivestreams/tck/PublisherScanWithLifetimeTckTest.java
Outdated
Show resolved
Hide resolved
...cetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/ScanWithPublisherTest.java
Show resolved
Hide resolved
Scottmitch
approved these changes
Apr 7, 2021
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScanWithPublisher.java
Outdated
Show resolved
Hide resolved
...cetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/ScanWithPublisherTest.java
Outdated
Show resolved
Hide resolved
...cetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/ScanWithPublisherTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The existing Publisher.scanWith(...) operator is not exposing cancellations to the end user. Use cases that need to control resource lifetimes (ie. clean-up), can't do so on cancel.
Modifications:
Add a new Publisher operator, scanWithLifetime(ScanWithLifetimeMapper), that also captures cancellation and invokes an afterFinally callback on all terminal signal (complete, error & cancel).
Result:
A new lifetime aware scanWith operator.