gRPC deserializer, multiple nio buffers with multiple messages #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Motivation__ `ProtoBufSerializationProvider.ProtoDeserializer` when extracting NIO buffers incorrectly reads all bytes from the buffer instead of the length of one message. __Modification__ Read only the bytes representing a single message (`decodedLengthOfData`) while extracting the NIO buffers. __Result__ gRPC deserializer works with buffers having multiple NIO buffers and multiple proto messages.
idelpivnitskiy
approved these changes
Mar 19, 2021
Scottmitch
approved these changes
Mar 19, 2021
| @@ -172,7 +172,7 @@ private static boolean isCompressed(Buffer buffer) throws SerializationException | |||
| // into it. Later, proto parser will copy data from this temporary ByteBuffer again. | |||
| // To avoid unnecessary copying, we use newCodedInputStream(buffers, lengthOfData). | |||
| final ByteBuffer[] buffers = buffer.toNioBuffers(buffer.readerIndex(), | |||
| buffer.readableBytes()); | |||
| decodedLengthOfData); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ProtoBufSerializationProvider.ProtoDeserializerwhen extracting NIO buffers incorrectly reads all bytes from the buffer instead of the length of one message.Modification
Read only the bytes representing a single message (
decodedLengthOfData) while extracting the NIO buffers.Result
gRPC deserializer works with buffers having multiple NIO buffers and multiple proto messages.