Github Actions Remove --max-workers gradle param #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Our github action scripts explicitly set --max-workers but gradle can automatically infer the value based upon number of processors [1]. [1] https://docs.gradle.org/current/userguide/command_line_interface.html > Default is number of processors. Modifications: - Remove --max-workers param from github action scripts Result: Gradle will automatically determine the number of workers to use based upon available processors.
Scottmitch
commented
Mar 16, 2021
| @@ -63,7 +63,7 @@ jobs: | |||
| fi | |||
|
|
|||
| # Execute the gradlew command to publish the build | |||
| ./gradlew --parallel --max-workers=4$FIRST_GRADLE_TARGETS && ./gradlew$SECOND_GRADLE_TARGETS | |||
| ./gradlew --parallel$FIRST_GRADLE_TARGETS && ./gradlew$SECOND_GRADLE_TARGETS | |||
There was a problem hiding this comment.
note the lack of space is intentional as the variable value always starts with a space
bondolo
approved these changes
Mar 17, 2021
|
I've done 3-4 builds and build time doesn't seem to be impacted. I'll merge and observe if build times change at all over time. |
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Mar 18, 2021
Motivation: Our github action scripts explicitly set --max-workers but gradle can automatically infer the value based upon number of processors [1]. [1] https://docs.gradle.org/current/userguide/command_line_interface.html > Default is number of processors. Modifications: - Remove --max-workers param from github action scripts Result: Gradle will automatically determine the number of workers to use based upon available processors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our github action scripts explicitly set --max-workers but gradle can
automatically infer the value based upon number of processors [1].
[1] https://docs.gradle.org/current/userguide/command_line_interface.html
Modifications:
Result:
Gradle will automatically determine the number of workers to use based
upon available processors.