RangeIntPublisher add explicit cast to int #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RangeIntPublisher relies upon an implict case from long to int which is gaurded by a `min(int, long)` (where the int is non-negative). CodeQL highlights this as a warning. Modifications: - Add an explicit cast to int to be more clear this is intentional Result: CodeQL warning is resovled.
|
Here are the warnings found: https://github.com/apple/servicetalk/security/code-scanning?query=ref%3Arefs%2Fpull%2F1442%2Fmerge+tool%3ACodeQL |
|
trivial change, will merge. |
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Mar 16, 2021
Motivation: RangeIntPublisher relies upon an implict case from long to int which is gaurded by a `min(int, long)` (where the int is non-negative). CodeQL highlights this as a warning. Modifications: - Add an explicit cast to int to be more clear this is intentional Result: CodeQL warning is resovled.
|
The change LGTM, but while I was looking at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RangeIntPublisher relies upon an implict case from long to int which is
gaurded by a
min(int, long)(where the int is non-negative). CodeQLhighlights this as a warning.
Modifications:
Result:
CodeQL warning is resovled.