Add Publisher.from(..) 2 and 3 arity overloads #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Publisher.from(..) with 2 or 3 arguments is becoming more common in control flow, and we currently have to allocate an array in these scenarios. Specialized implementations for this operator can avoid array allocation and more complex index/state management. Modifications: - Add Publisher.from(T, T) and Publisher.from(T, T, T) Result: Publisher.from(..) is less resource intensive for 2 and 3 arity use cases.
bondolo
approved these changes
Mar 15, 2021
|
build failure attributed to #1277 |
|
LGTM, submitted #1439 for the javadoc typo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher.from(..) with 2 or 3 arguments is becoming more common in
control flow, and we currently have to allocate an array in these
scenarios. Specialized implementations for this operator can avoid array
allocation and more complex index/state management.
Modifications:
Result:
Publisher.from(..) is less resource intensive for 2 and 3 arity use
cases.