Allow client security configuration without trust material #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Trust material is optional for the client-side security configuration and we should allow using the default JDK truststore. Modifications: - If users of deprecated `ClientSecurityConfig` did not specify a trust material, use default `ClientSslConfigBuilder` ctor; Result: Users of deprecated `ClientSecurityConfig` can create a security config with default JDK truststore.
|
The fix is trivial, I will pull this in. |
idelpivnitskiy
added a commit
that referenced
this pull request
Mar 12, 2021
Motivation: Trust material is optional for the client-side security configuration and we should allow using the default JDK truststore. Modifications: - If users of deprecated `ClientSecurityConfig` did not specify a trust material, use default `ClientSslConfigBuilder` ctor; Result: Users of deprecated `ClientSecurityConfig` can create a security config with default JDK truststore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Trust material is optional for the client-side security configuration
and we should allow using the default JDK truststore.
Modifications:
ClientSecurityConfigdid not specify atrust material, use default
ClientSslConfigBuilderctor;Result:
Users of deprecated
ClientSecurityConfigcan create a security configwith default JDK truststore.