FlakyTest: CancellationTest - Improve close handling #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
force-pushed
the
impr/cancellationtest-capture-stack
branch
from
c8beae1 to
60ee945
Compare
tkountis
changed the title
tkountis
changed the title
tkountis
force-pushed
the
impr/cancellationtest-capture-stack
branch
3 times, most recently
from
82a2381 to
1c27d2d
Compare
bondolo
approved these changes
Mar 4, 2021
...-router-jersey/src/testFixtures/java/io/servicetalk/http/router/jersey/CancellationTest.java
Outdated
Show resolved
Hide resolved
Scottmitch
reviewed
Mar 5, 2021
...-router-jersey/src/testFixtures/java/io/servicetalk/http/router/jersey/CancellationTest.java
Outdated
Show resolved
Hide resolved
(cherry picked from commit bb54b62)
tkountis
force-pushed
the
impr/cancellationtest-capture-stack
branch
from
1c27d2d to
e39accf
Compare
tkountis
force-pushed
the
impr/cancellationtest-capture-stack
branch
from
e39accf to
aa23a19
Compare
tkountis
changed the title
tkountis
commented
Mar 24, 2021
|
|
||
| @Override | ||
| public boolean hasEntity() { | ||
| if (state == State.CLOSED) { |
Scottmitch
reviewed
Mar 25, 2021
...-router-jersey/src/testFixtures/java/io/servicetalk/http/router/jersey/CancellationTest.java
Outdated
Show resolved
Hide resolved
...jersey/src/main/java/io/servicetalk/http/router/jersey/DefaultJerseyStreamingHttpRouter.java
Outdated
Show resolved
Hide resolved
...-router-jersey/src/testFixtures/java/io/servicetalk/http/router/jersey/CancellationTest.java
Outdated
Show resolved
Hide resolved
tkountis
force-pushed
the
impr/cancellationtest-capture-stack
branch
from
1c8e8e1 to
27e12f6
Compare
bondolo
reviewed
Apr 1, 2021
|
Build failure attributed to #1467 |
Scottmitch
reviewed
Apr 1, 2021
...-router-jersey/src/testFixtures/java/io/servicetalk/http/router/jersey/CancellationTest.java
Outdated
Show resolved
Hide resolved
...jersey/src/main/java/io/servicetalk/http/router/jersey/DefaultJerseyStreamingHttpRouter.java
Outdated
Show resolved
Hide resolved
...jersey/src/main/java/io/servicetalk/http/router/jersey/DefaultJerseyStreamingHttpRouter.java
Show resolved
Hide resolved
...jersey/src/main/java/io/servicetalk/http/router/jersey/DefaultJerseyStreamingHttpRouter.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
EntityInputStreamis not thread safe, and the cancellation is triggering aclosefrom any thread, while the access path is through the offloaded thread.Modifications:
Extend the
ContainerRequestto capture close and handoff it to the offloaded thread if a read is already in progress, or close it atomically otherwise.Result:
Better thread visibility and serialization of events in case of a read is in progress.
Fixes: #999