Close ServerContext before Executor in AbstractNettyHttpServerTest #1101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Because the server's executor is closed before the server, all tests
from
AbstractNettyHttpServerTest
subclasses printTaskBasedSignalOffloader - Failed to execute task on the executor
errors that pollute logs and make the build log unreadable.
Modifications:
ServerContext
beforeExecutor
inAbstractNettyHttpServerTest
;Result:
No
TaskBasedSignalOffloader
errors in test logs.Example of the polluted logs: