Improve LoadBalancerFactory#newLoadBalancer() generics
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Motivation__ `LoadBalancerFactory#newLoadBalancer()` does not allow for the passed `ConnectionFactory` to influence type of the `LoadBalancedConnection` managed by the returned `LoadBalancer`. This forces users of this API (Http client builder implementations) to do an explicit cast. __Modification__ Improve generics of `LoadBalancerFactory#newLoadBalancer()` to infer the returned `LoadBalancer` generics from the passed `ConnectionFactory` __Result__ No explicit casts while using `LoadBalancerFactory#newLoadBalancer()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LoadBalancerFactory#newLoadBalancer()does not allow for the passedConnectionFactoryto influence type of theLoadBalancedConnectionmanaged by the returnedLoadBalancer. This forces users of this API (Http client builder implementations) to do an explicit cast.Modification
Improve generics of
LoadBalancerFactory#newLoadBalancer()to infer the returnedLoadBalancergenerics from the passedConnectionFactoryResult
No explicit casts while using
LoadBalancerFactory#newLoadBalancer().