SingleConcatWithPublisher and invalid request-n
#1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@NiteshKant - The commit message has an extra back-tick which is confusing the markdown parsing. |
Scottmitch
approved these changes
May 6, 2020
...nt-api/src/test/java/io/servicetalk/concurrent/api/single/SingleConcatWithPublisherTest.java
Show resolved
Hide resolved
__Motivation__ If invalid calls to request-n are made for `Single.concat(Publisher)` before the `Single` result is propagated, we first emit the result and then propagate the invalid demand. For cases, when the concatenated `Publisher` completes inline with `subscribe()` (eg: `Publisher.empty()`), this means we will never deliver an error for the invalid demand. __Modification__ Deliver error when invalid demand is made in the above case instead of `Single`'s result and do not subscribe to the concatenated `Publisher` __Result__ Invalid demand always terminates the `Subscriber` with an error.
NiteshKant
pushed a commit
to NiteshKant/servicetalk
that referenced
this pull request
May 6, 2020
__Motivation__ If invalid calls to request-n are made for `Single.concat(Publisher)` before the `Single` result is propagated, we first emit the result and then propagate the invalid demand. For cases, when the concatenated `Publisher` completes inline with `subscribe()` (eg: `Publisher.empty()`), this means we will never deliver an error for the invalid demand. __Modification__ Deliver error when invalid demand is made in the above case instead of `Single`'s result and do not subscribe to the concatenated `Publisher` __Result__ Invalid demand always terminates the `Subscriber` with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If invalid calls to request-n are made for
Single.concat(Publisher)before theSingleresult is propagated, we first emit the result and then propagate the invalid demand.For cases, when the concatenated
Publishercompletes inline withsubscribe()`` (eg:Publisher.empty()`), this means we will never deliver an error for the invalid demand.Modification
Deliver error when invalid demand is made in the above case instead of
Single's result and do not subscribe to the concatenatedPublisherResult
Invalid demand always terminates the
Subscriberwith an error.