Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Update to work with Selenium 4 (with element factory) #469

Merged
merged 23 commits into from
Oct 15, 2021
Merged
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c1e80a7
Add most fixes
TroyWalshProf Sep 8, 2021
6e0af66
Get proect to build
TroyWalshProf Sep 8, 2021
c9b612c
Use new platform setting more consistantly
TroyWalshProf Sep 10, 2021
d04122f
Get WinAppTests kind of working
TroyWalshProf Oct 1, 2021
e3c1ef2
Drop one off web elements
TroyWalshProf Oct 7, 2021
ffaa237
Use Selenium 4 RC2 and remove extra using statements
TroyWalshProf Oct 7, 2021
8f778f0
Cleanup mobile selectors and image compare test
TroyWalshProf Oct 7, 2021
7f33808
Fix mobile By bug
TroyWalshProf Oct 7, 2021
8bed9fe
Undo local test code
TroyWalshProf Oct 7, 2021
b7b2a97
Merge branch 'master' into master
TroyWalshProf Oct 7, 2021
6f0ecad
Address PR comments
TroyWalshProf Oct 8, 2021
93300a7
Merge branch 'master' of https://github.com/TroyWalshProf/appium-dotn…
TroyWalshProf Oct 8, 2021
a559075
Add back IdempotencyHeader
TroyWalshProf Oct 8, 2021
036e540
PR related cleanup
TroyWalshProf Oct 8, 2021
cb5970f
Update to latest Selenium RC
TroyWalshProf Oct 8, 2021
6eb65d9
Update PageObjects code to work with new Element and driver paradigm
TroyWalshProf Oct 8, 2021
85f66a5
Work with web element factory
TroyWalshProf Oct 10, 2021
0cf8a40
Update to work with upcoming RC4
TroyWalshProf Oct 11, 2021
2aac534
Move to official release as there will be no RC4
TroyWalshProf Oct 12, 2021
c55410b
Update copyright
TroyWalshProf Oct 13, 2021
d60ee40
Put Newtonsoft back
TroyWalshProf Oct 13, 2021
2f7a699
Use ternary operator
TroyWalshProf Oct 13, 2021
92e6864
Remove outdated using statements
TroyWalshProf Oct 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Appium.Net/Appium/iOS/IOSDriver.cs
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@

namespace OpenQA.Selenium.Appium.iOS
{

public class IOSDriver : AppiumDriver, IFindByIosUIAutomation<IWebElement>, IFindsByIosClassChain<IWebElement>,
IFindsByIosNSPredicate<IWebElement>, IHidesKeyboardWithKeyName, IHasClipboard,
IShakesDevice, IPerformsTouchID, IHasSettings
2 changes: 2 additions & 0 deletions test/integration/IOS/SettingTest.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Appium.Net.Integration.Tests.helpers;
using NUnit.Framework;

using OpenQA.Selenium.Appium.iOS;

namespace Appium.Net.Integration.Tests.iOS
@@ -13,6 +14,7 @@ public void BeforeAll()
{
var capabilities = Caps.GetIosCaps(Apps.Get("iosUICatalogApp"));
var serverUri = Env.ServerIsRemote() ? AppiumServers.RemoteServerUri : AppiumServers.LocalServiceUri;

_driver = new IOSDriver(serverUri, capabilities, Env.InitTimeoutSec);
_driver.Manage().Timeouts().ImplicitWait = Env.ImplicitTimeoutSec;
}