This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
feat: Allow to enable the access to the system shell via server features #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Dec 18, 2019
| * @throws {Error} If there was a problem during command execution | ||
| */ | ||
| commands.execute = async function execute (script, args) { | ||
| this.ensureFeatureEnabled(SYSTEM_SHELL_FEATURE); |
There was a problem hiding this comment.
Will we add this feature flag in readme like other modules?
There was a problem hiding this comment.
Sorry, I'm sometimes being lazy with documenting all the stuff. I've tried to provide accurate docstrings in the source though ;)
There was a problem hiding this comment.
@mykola-mokhnach can you please provide an example of how to actually execute a simple shell command once this feature has been enabled when starting appium server? im unsure how to use with my driver? I'm using C# fyi. Appreciate any help. Thanks :)
imurchie
approved these changes
Dec 18, 2019
This was referenced Dec 19, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People were asking for such functionality, so lets make them happy