Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: system prompt for Apple ID sign in unexpectedly not translated #431

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix: system prompt for Apple ID sign in unexpectedly not translated #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94656be
fix: system prompt for Apple ID sign in unexpectedly not translated
mwakizaka Jun 5, 2024
b5f5d91
fix: unit test
mwakizaka Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/extensions/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { fs } from '@appium/support';
// com.apple.SpringBoard: translates com.apple.SpringBoard and system prompts for push notification
// com.apple.locationd: translates system prompts for location
// com.apple.tccd: translates system prompts for camera, microphone, contact, photos and app tracking transparency
const SERVICES_FOR_TRANSLATION = ['com.apple.SpringBoard', 'com.apple.locationd', 'com.apple.tccd'];
// com.apple.akd: translates `Sign in with your Apple ID` system prompt
const SERVICES_FOR_TRANSLATION = ['com.apple.SpringBoard', 'com.apple.locationd', 'com.apple.tccd', 'com.apple.akd'];
const GLOBAL_PREFS_PLIST = '.GlobalPreferences.plist';
const PREFERENCES_PLIST_GUARD = new AsyncLock();
const DOMAIN = /** @type {const} */ Object.freeze({
Expand Down
5 changes: 4 additions & 1 deletion test/unit/simulator-specs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@ launchd_s 35621 mwakizaka 16u unix 0x7b7dbedd6d62e84f 0t0 /private/
spawnProcessSpy.getCall(3).args[0].should.eql(
['launchctl', 'stop', 'com.apple.tccd']
);
spawnProcessSpy.callCount.should.eql(4);
spawnProcessSpy.getCall(4).args[0].should.eql(
['launchctl', 'stop', 'com.apple.akd']
);
spawnProcessSpy.callCount.should.eql(5);
});

it('should confirm skip restarting services if already applied', async function () {
Expand Down
Loading