refactor!: Update to work with Selenium 4 (with element factory) #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'App' as a known capablity Transition from AddAdditionalCapability to AddAdditionalOption
Update tests to leverage configuration DeviceName and AddAdditionalAppiumOption
6 tasks
|
|
||
| public new IReadOnlyCollection<W> FindElements(string selector, string value) => | ||
| ConvertToExtendedWebElementCollection<W>(base.FindElements(selector, value)); | ||
|
|
||
| public new W FindElementByClassName(string className) => | ||
| (W) base.FindElement(MobileSelector.ClassName, className); | ||
| public W FindElementByClassName(string className) => |
There was a problem hiding this comment.
TBH I would love for all these helpers to go away, but I am guessing I am in the minority
There was a problem hiding this comment.
Please feel free to remove them. They're inherited
There was a problem hiding this comment.
@akinsolb, they are no longer inherited and simply pulling them will break a lot of tests.
I think we should look at this more holistically but in a sperate PR.
AKA would like to get what we have released as a Alpha or Beta today if possible.
There was a problem hiding this comment.
we are anyway doing a major release, so it's fine to do such breaking change
mykola-mokhnach
approved these changes
Oct 13, 2021
|
Also, it looks like tests need some love. |
|
As discussed earlier , merging this into a release branch today |
laolubenson
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Transition off Remote elements and drivers
Stop using capabilities, instead leverage the base DriverOptions functionality
Transition from AddAdditionalCapability to AddAdditionalOption
Add 'App' as a known capability
Tag driver options so they are W3C compliant
Transition from CommandInfo to HttpCommandInfo
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Update to work with Selenium 4/to be W3C compliant