This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: Parse JSON for updateSettings #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,20 @@ export default class Actions extends Component { | |||
| } | |||
| } | |||
|
|
|||
| // Special case for 'updateSettings' | |||
| if (action.methodName === 'updateSettings') { | |||
| if (_.isString(args[0])) { | |||
There was a problem hiding this comment.
this if could be combined with the previous one using &&
| args[0] = JSON.parse(args[0]); | ||
| } catch (e) { | ||
| notification.error({ | ||
| message: t('invalidJson', {json: args[1]}), |
There was a problem hiding this comment.
do we know that we have at least 2 args?
There was a problem hiding this comment.
or it should be args[0]?
There was a problem hiding this comment.
Good catch, thanks.
|
Hi @dpgraham Thanks for this fix. Is this already in the latest release? I tried this with the 1.12.0 and it still fails |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to parse 'settings' JSON before passing it through to wd
(cc: @wswebcreation)