This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
add basic recording functionality #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgraham
approved these changes
Jun 23, 2017
| <Tooltip title="Pause Recording"> | ||
| <Button icon="pause" onClick={pauseRecording}/> | ||
| </Tooltip> | ||
| } |
There was a problem hiding this comment.
Is there a way to reset the recording?
| return async (dispatch) => { | ||
| return async (dispatch, getState) => { | ||
| let isRecording = params.methodName !== 'quit' && | ||
| params.methodName !== 'source' && |
There was a problem hiding this comment.
The methodName is never set to source. The source method is called every time.
If we were to add source as a client method call, though, I think we'd want to record it.
| @@ -0,0 +1,93 @@ | |||
| export default class Framework { | |||
|
|
|||
There was a problem hiding this comment.
Could we put client-frameworks and highlighting directories into a utils or helpers directory?
| <Button icon="delete" onClick={clearRecording} size="small" /> | ||
| </Tooltip> | ||
| } | ||
| {!isRecording && |
There was a problem hiding this comment.
These three instances of !!recorderActions.length && can be replaced with one and you can either wrap the three components in a div or make them an array. Not a big deal if left as is though.
…ipboard copy feature
|
ok @dpgraham all comments addressed and ruby/python frameworks added |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added action recorder and code generator