This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Add buttons that scroll source left and right #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added component that has a left and right scroll button that takes a container as an argument * Clicking left makes the scrollLeft -= 20, click right makes the scrollLeft += 20 * Doesn't show component if clientWidth > scrollWidth
For some reason antd has a max height on the ant-spin of 320 px which was causing the spinner to not be centered
|
All looks good to me, however I noticed that if I open the inspector in its default size, and then simply open up the xml document from there, the buttons don't show up. I actually have to trigger a resize event. Can we hook this up to check the state based on other actions in the tree? That way it can remember to check whether we need to show the buttons if we just click on a tree element that happens to expand out wide. |
|
I made it so that whenever the source is clicked on, it checks again to determine if we should see the scroll buttons or not. In the case you're talking about, is it actually invisible in spite of the fact that the XML is too large? |
dpgraham
added a commit
that referenced
this pull request
May 15, 2017
* Add buttons that scroll source left and right * Added component that has a left and right scroll button that takes a container as an argument * Clicking left makes the scrollLeft -= 20, click right makes the scrollLeft += 20 * Doesn't show component if clientWidth > scrollWidth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(reviewer @jlipps)