This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
WIP: Testing still... Revert "Get source, screenshot and windowSize concurrently" #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd2fb93.
dpgraham
changed the title
|
This doesn't fix the issue. |
|
@dpgraham I am just providing more information to narrow down this issue. It works perfectly fine on v1.12.0 but not on v1.12.1. We just need to compare the changes done between these versions. I am trying from my side as well. |
|
@dpgraham Can you kindly retry the revert as per our testing it does fix the issue - at least for Perfecto cloud provider. |
|
@danieltg I don't have time, but I'll just leave this as-is until I get around to it again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #916
Causing race conditions that cause the spinner to act indefinitely