Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log to cli and make examples work #81

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

appcypher
Copy link
Owner

Description

This PR includes several significant updates across the codebase:

  1. Added new logging functionality:

    • Implemented mc log command with options for lines (-n), no-pager, and follow (-f)
    • Added log streaming support with async capabilities
  2. Improved example applications:

    • Added new microvm_counter example demonstrating Python and Shell implementations
    • Updated all examples to use consistent image reference parsing
    • Standardized rootfs directory path handling
  3. Enhanced documentation:

    • Expanded README.md with more detailed features and examples
    • Added comprehensive configuration schema documentation
    • Updated troubleshooting section with macOS-specific guidance
  4. Code organization and cleanup:

    • Moved monocore.entitlements to root directory
    • Updated Makefile paths to reflect new entitlements location

Link to issue

N/A - Feature enhancement and code organization

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change that improves existing functionality)
  • This change requires a documentation update

Test plan (required)

  1. Test new logging functionality:
mc up -f monocore.example.toml
mc log sh-counter
mc log python-counter -n 5
mc log sh-counter -f
  1. Verify example applications:
make example microvm_counter
make example microvm_curl
make example microvm_shell
  1. Confirm documentation accuracy:
  • Review updated README.md
  • Verify configuration schema examples
  • Test all documented commands

- Added new dependencies: `async-stream`, `pin-project`, and `rand` to `Cargo.toml` and `Cargo.lock`.
- Updated service configurations in `monocore.example.toml` and `monocore.example.json` to improve RAM allocation and command execution.
- Enhanced logging capabilities by introducing a new log command in the CLI for better service monitoring.

These changes improve dependency management and enhance the overall configuration and logging experience for users.
@appcypher appcypher merged commit e6b39e0 into main Dec 11, 2024
6 checks passed
@appcypher appcypher deleted the appcypher/cli-log branch December 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant