perf(store): optimize chunker cloning in stores fixing stack overflow #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix stack overflow in test_ops_rename by wrapping chunkers and layouts in Arc to avoid expensive cloning in MemoryStore and FlatFsStore. This significantly improves performance for deep recursive operations. Key changes: - Fix potential stack overflow in directory rename operations - Wrap chunkers and layouts in Arc in MemoryStore and FlatFsStore - Update FastCDC and GearCDC to use Arc for gear tables - Add directory tree visualization utility as a bonus feature The performance improvement is particularly noticeable in deep recursive operations like directory renames, where multiple store clones were previously occurring.
appcypher
added a commit
that referenced
this pull request
Feb 6, 2025
…moryStore APIs (#128) * refactor(store): improve FlatFsStore and MemoryStore APIs - Make reference counting optional in FlatFsStore - Add TypedBuilder for better store configuration - Rename FlatFsStoreDefault to FlatFsStore - Improve documentation for both stores - Remove LRU dependency - Simplify store constructors by using builder pattern - Add tests for disabled reference counting * perf(store): optimize chunker cloning in stores fixing stack overflow (#129) Fix stack overflow in test_ops_rename by wrapping chunkers and layouts in Arc to avoid expensive cloning in MemoryStore and FlatFsStore. This significantly improves performance for deep recursive operations. Key changes: - Fix potential stack overflow in directory rename operations - Wrap chunkers and layouts in Arc in MemoryStore and FlatFsStore - Update FastCDC and GearCDC to use Arc for gear tables - Add directory tree visualization utility as a bonus feature The performance improvement is particularly noticeable in deep recursive operations like directory renames, where multiple store clones were previously occurring. * test: improve test documentation and isolation - Add mutex to synchronize stdout redirection in tests - Add ignore attributes to directory tree tests that use stdout - Fix example code in print_dir_tree documentation - Add documentation for monofs directory tree tests explaining stdout issues - Add descriptive reasons for ignored Docker registry tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stack overflow in test_ops_rename by wrapping chunkers and layouts in Arc to avoid expensive cloning in MemoryStore and FlatFsStore. This significantly improves performance for deep recursive operations.
Key changes:
The performance improvement is particularly noticeable in deep recursive operations like directory renames, where multiple store clones were previously occurring.