Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service labels #249

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Service labels #249

merged 2 commits into from
Sep 26, 2016

Conversation

subfuzion
Copy link
Contributor

@subfuzion subfuzion commented Sep 25, 2016 •
edited
Loading

Closes #248

Adds service label option to CLI service create command, cleans up related service/stack code, updates test stackfiles.

Verification

Merge #244 first

$ make test

$ make install
# start amplifier
$ amp service create -l foo=bar --label hello=world --name pinger appcelerator/pinger
# verify labels [foo:bar, hello:world]
$ docker service inspect -f '{{ .Spec.Labels }}' pinger
$ docker service rm pinger

@subfuzion subfuzion changed the title Labels Service labels Sep 25, 2016
@subfuzion subfuzion mentioned this pull request Sep 25, 2016
Merged
freignat91
freignat91 approved these changes Sep 26, 2016
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok (including with stack)

@subfuzion subfuzion merged commit 34425b0 into master Sep 26, 2016
@subfuzion subfuzion deleted the labels branch September 26, 2016 17:04
@subfuzion subfuzion added this to the 0.1.1 milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalhenry generalhenry generalhenry approved these changes

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@subfuzion @generalhenry @freignat91