Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container labels #251

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Container labels #251

merged 1 commit into from
Sep 26, 2016

Conversation

subfuzion
Copy link
Contributor

@subfuzion subfuzion commented Sep 25, 2016 •
edited
Loading

Closes #250

Verification

Merge #249 first.

$ make test

$ make install
# start amplifier
$ amp service create --name pinger --container-label foo=bar --container-label hello=world appcelerator/pinger
$ docker inspect -f '{{ .Spec.ContainerSpec.Labels }}' pinger
$ docker service rm pinger

@subfuzion subfuzion mentioned this pull request Sep 26, 2016
Merged
freignat91
freignat91 approved these changes Sep 26, 2016
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok
but executed 'docker service rm pinger' in place of 'docker rm pinger'
tested ok also with stack with use container labels

@chrisccoy
Copy link
Contributor

👍 , needs rebase

@chrisccoy
Copy link
Contributor

looks good

@chrisccoy chrisccoy merged commit 7bc3583 into master Sep 26, 2016
@chrisccoy chrisccoy deleted the container-labels branch September 26, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalhenry generalhenry generalhenry approved these changes

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@subfuzion @chrisccoy @generalhenry @freignat91