Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs message filter now takes regexes #1582

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Logs message filter now takes regexes #1582

merged 2 commits into from
Aug 1, 2017

Conversation

JosephGJ
Copy link
Contributor

fixes #1574

Message flag now takes regexes.

@JosephGJ JosephGJ requested a review from bquenin July 25, 2017 20:28
@JosephGJ JosephGJ force-pushed the logs-message-regex branch from eafba25 to 2e12c9c Compare July 25, 2017 20:29
bquenin
bquenin suggested changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start. You also need to tackle the logs streaming aspect and may want to add some tests.

@JosephGJ JosephGJ force-pushed the logs-message-regex branch 3 times, most recently from 362b73f to 18a1dfa Compare July 31, 2017 22:08
@ndegory
Copy link
Contributor

ndegory commented Aug 1, 2017

@JosephGJ still planning for 0.14?

@JosephGJ JosephGJ added this to the 0.14 milestone Aug 1, 2017
@JosephGJ
Copy link
Contributor Author

JosephGJ commented Aug 1, 2017

@ndegory I'll be able to get this in for 0.14, I'm just updating the smoke tests.

@JosephGJ JosephGJ force-pushed the logs-message-regex branch from 7cfe6dd to 0b844a3 Compare August 1, 2017 21:22
@JosephGJ JosephGJ force-pushed the logs-message-regex branch from 0b844a3 to 1c657ca Compare August 1, 2017 21:28
@subfuzion subfuzion merged commit 9c6f50c into master Aug 1, 2017
@subfuzion subfuzion deleted the logs-message-regex branch August 1, 2017 21:54
@subfuzion subfuzion mentioned this pull request Aug 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

Assignees
No one assigned
Labels
area/cli area/logging
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

amp logs message filter should support regular expression
4 participants
@JosephGJ @ndegory @bquenin @subfuzion