This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
lib/internal: allow auto fallback from v2 API to v1 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #221 docker2aci would only attempt the v2 api if a registry supported it. this check for a 404 error from the v2 api and if so attempts to fallback to v1. Workflow: probe v2, try v2, downgrade-on-failure, probe v1, try v1, hardfail-on-failure
|
Hmm, I don't really understand the build failure from the ci: |
|
That's some weird Semaphore flake where I think it doesn't check out the repository properly. I restarted it. |
|
LGTM. @lucab ? |
|
Code LGTM, but I'll give this a spin inside rkt testsuite just to make sure that we don't hit further regressions. |
|
rkt testsuite is green too, merging. Thanks a lot @stuart-warren for your patches! |
This was referenced Nov 8, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #221
docker2aci would only attempt the v2 api if a registry supported it.
this check for a 404 error from the v2 api and if so attempts to
fallback to v1.
Workflow:
probe v2, try v2, downgrade-on-failure, probe v1, try v1,
hardfail-on-failure