This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
log: introduce Logger interface #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did this in the plane, so let's see, if I pass the CI. |
|
LGTM, thanks for the refactoring! |
|
Needs a rebase |
added 2 commits
November 2, 2016 12:40
The type common.ParsedDockerURL is aliased to types.ParsedDockerURL which is unnecessary. This removes the alias, and moves the type from the internal `types` package to the `common` package. Additionally common.ParseDockerURL is only delegating to types.ParseDockerURL which is unnecessary. This moves the implementation from the internal `types` package to the `common` package.
This introduces a new Logger interface to allow swappable `debug`, and `info` loggers for consumers of the library. These loggers are compatible with the "log" stdlib logger. Fixes appc#136
|
Rebased, LGTM, merging. And thanks :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new Logger interface to allow swappable
debug, andinfologgers for consumers of the library.These loggers are compatible with the "log" stdlib logger.
This PR also does a refactoring/cleanup in preparation for #216.
Fixes #136