This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
backend/repository: assume no v2 on unexpected status #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
reviewed
Oct 23, 2016
| return false, nil | ||
| } | ||
|
|
||
| return false, fmt.Errorf("unexpected http code: %d", statusCode) |
There was a problem hiding this comment.
I think this is a compilation failure, since there is nothing returned.
There was a problem hiding this comment.
Local build+test seems fine (go 1.6.3), but I see over-zealous checkers may get confused. I'll switch to a false-return at the bottom.
This commit changes version detection behavior to align with Registry v2 specs: ``` If 404 Not Found response status, or other unexpected status, is returned, the client should proceed with the assumption that the registry does not implement V2 of the API. ``` Reference: https://docs.docker.com/registry/spec/api/#/api-version-check
lucab
force-pushed
the
to-upstream/registry-v2-check
branch
from
5267ab9 to
3c4ca52
Compare
|
@s-urbaniak rebased, PTAL. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes version detection behavior to align with
Registry v2 specs:
Reference: https://docs.docker.com/registry/spec/api/#/api-version-check
Fixes #85