[Vue] Use lazy & onChange for DynamicRangeSlider #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Vue DynamicRangeSlider will not update the search query if you click on the rail or if you use the keyboard controls.
By listening to the
changeevent from the VueSlider and setting it tolazy, we get the same behavior as the listeningdrag-endevent except clicking on the rail actually works properly.I will add that it might be worth disabling the keyboard controls entirely with
useKeyboard={false}. The keyboard controls will cause many requests if you, for example, hold a direction, and the lazy property does not fix that. Plus the keyboard controls are kinda bad anyway 😅